Refactor logging and statistics source files #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulugetam
force-pushed
the
refactor_logging_src
branch
from
7fe4e75 to
74d7f48
Compare
Contributor
|
Hi, you would need to also modify all the logging instances to switch to the new style. the logs are currently mangled. |
Contributor
|
Also what happens if multiple threads are concurrently accessing the logfile? we may need synchronization |
mulugetam
force-pushed
the
refactor_logging_src
branch
2 times, most recently
from
aeaf218 to
a17d82c
Compare
…e specifically: - Avoid C variable args, use variadic templates instead. - Avoid raw pointers. - Avoid C arrays. - Use scoped enums Signed-off-by: Mulugeta Mammo <[email protected]>
Contributor
Author
|
Closing this in favor of #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor logging and statistics source files based on ISO C++ Core Guidelines. More specifically: